ISPN-14164 Fix metrics produced by the Infinispan server for Prometheus scraping #10342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanemerson
approved these changes
Sep 23, 2022
|
Thanks @ryanemerson for the review |
jabolina
reviewed
Sep 23, 2022
Comment on lines
+17
to
+20
| private RestServerHelper restServer; | ||
| private RestClient restClient; |
There was a problem hiding this comment.
CI is complaining about a thread leaking, I think we need to stop these two.
There was a problem hiding this comment.
good catch thank you @jabolina
That is now the CONTENT_TYPE_004 "text/plain; version=0.0.4"
We cannot use filters since we're going to merge the registries to fix the issue in the next commit :(
This should fix the issue
fax4ever
force-pushed
the
ISPN-14164
branch
from
97735a2
to
c0dde09
Compare
|
@jabolina thanks for the review, I fixed the test ;) |
jabolina
approved these changes
Sep 23, 2022
|
Thank you, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14164
https://issues.redhat.com/browse/JDG-5583