Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14169 Correctly handle empty YAML elements #10344

Merged
merged 1 commit into from Sep 26, 2022

Conversation

tristantarrant
Copy link
Member

@ryanemerson
Copy link
Contributor

Thanks @tristantarrant, I know how much you hate the yaml parser 😄

@tristantarrant
Copy link
Member Author

My issue is with YAML, not with the parser :)
https://github.com/infinispan/infinispan/blob/main/commons/all/src/test/java/org/infinispan/commons/configuration/io/yaml/YamlConfigurationReaderTest.java#L114

@tristantarrant tristantarrant modified the milestones: 14.0.0.CR2, 14.0.0.Final Sep 26, 2022
Copy link
Member

@jabolina jabolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jabolina jabolina merged commit 8f26523 into infinispan:main Sep 26, 2022
@jabolina
Copy link
Member

Merged, thanks @tristantarrant

@tristantarrant tristantarrant deleted the ISPN-14169/yaml_empty branch April 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants