ISPN-14171 Support RFC 6598 shared address space addresses #10345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
reviewed
Sep 27, 2022
| this.prefixLength = 4; | ||
| } else if (a[0] == (byte) 100 && a[1] >= (byte) 64) { |
There was a problem hiding this comment.
Suggested change
| } else if (a[0] == (byte) 100 && a[1] >= (byte) 64) { | |
| } else if (a[0] == (byte) 100 && a[1] >= (byte) 64 && a[1] <= (byte) 127) { |
There was a problem hiding this comment.
the beauty of signed values
jabolina
approved these changes
Sep 27, 2022
tristantarrant
force-pushed
the
ISPN-14171/rfc6598
branch
from
918cd39
to
4a0da6a
Compare
|
@jabolina I've changed the code so that it is much more extensible and will also support custom ranges in the future |
jabolina
approved these changes
Sep 27, 2022
|
Merged, thanks @tristantarrant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14171