Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0.x]ISPN-14267-14 fix docs formatting #10429

Merged
merged 2 commits into from Nov 4, 2022
Merged

[14.0.x]ISPN-14267-14 fix docs formatting #10429

merged 2 commits into from Nov 4, 2022

Conversation

domiborges
Copy link
Member

Backports #10421
https://issues.redhat.com/browse/ISPN-14267
fixes docs formatting
includes rbac content in the embedded guide

@domiborges domiborges added Trivial :-) Documentation Pull request containing only documentation changes labels Nov 2, 2022
@dfitzmau
Copy link
Contributor

dfitzmau commented Nov 2, 2022

Backports #10421 https://issues.redhat.com/browse/ISPN-14267 fixes docs formatting includes rbac content in the embedded guide

Hi @dvagnero . Do you know of the quickest way that I can use to build the guide from my local machine, so I can create the spacing formatting is fixed?

@domiborges
Copy link
Member Author

@dfitzmau Do you remember how to contribute to somebody's PR? It's the same. Add my fork as a remote, pull this branch and then you can build locally.

@dfitzmau
Copy link
Contributor

dfitzmau commented Nov 2, 2022

@dfitzmau Do you remember how to contribute to somebody's PR? It's the same. Add my fork as a remote, pull this branch and then you can build locally.

OK. I'll pull out my instructions that I've written somewhere. I'll aim to do this first thing tomorrow morning.

dfitzmau
dfitzmau approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@dfitzmau dfitzmau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dvagnero .

I finally built a local version of the server guide by issuing the following commands:

  1. git fetch name
  2. git checkout name/ISPN-14267-14
  3. git switch -c ISPN-14267-14

Content LGTM.

ksnip_20221104-093644

@domiborges
Copy link
Member Author

Great. Thanks!

@domiborges domiborges changed the title [14.0.x]ISPN-14267-14 [14.0.x]ISPN-14267-14 fix docs formatting Nov 4, 2022
@domiborges domiborges merged commit 1bfe766 into 14.0.x Nov 4, 2022
@domiborges domiborges deleted the ISPN-14267-14 branch November 4, 2022 10:04
@domiborges domiborges mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitzmau dfitzmau dfitzmau approved these changes

Assignees
No one assigned
Labels
Documentation Pull request containing only documentation changes Trivial :-)
Projects
None yet
Milestone
No milestone
2 participants
@domiborges @dfitzmau