Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recipes): Custom Vector Icons #108

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

lodev09
Copy link

@lodev09 lodev09 commented Nov 10, 2023

  • Closes Recipe for font icons #106
  • Implements custom @expo/vector-icons
  • Demonstrates how to use vector-icons into ignite instead of png

Feel free to edit flow, copy, etc.

@cdanwards
Copy link
Member

@lodev09 Sorry this sat for so long! I'm going to take a look at it this week.

@cdanwards cdanwards self-assigned this Apr 17, 2024
Copy link
Member

@cdanwards cdanwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lodev09 the content looks great! I was able to get it working pretty quickly with the instructions. I just left some comments to bring the markdown styles in line with other recipes, as well as our updated use of CNG workflow instead of Prebuild for expo! Thanks for the submission!

docs/recipes/CustomVectorIcons.md Outdated Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Show resolved Hide resolved
docs/recipes/CustomVectorIcons.md Outdated Show resolved Hide resolved
lodev09 and others added 19 commits April 19, 2024 23:03
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
@lodev09
Copy link
Author

lodev09 commented Apr 19, 2024

@cdanwards done.. Thanks so much!

@frankcalise
Copy link
Contributor

Thanks for the contribution!

Curious, could we utilize something like this for the font loading rather than downloading font files? Thoughts?

https://github.com/expo/examples/blob/master/with-router-menus/src/app/_layout.tsx#L14-L17

@lodev09
Copy link
Author

lodev09 commented May 8, 2024

@frankcalise for sure. The recipe shows downloading these fonts because it's from FontAwesome 6 which is not provided by expo vector icons (since this is a pro version). When using those free ones, it should work as-is following their instruction

@lodev09
Copy link
Author

lodev09 commented May 8, 2024

I could add a note in the recipe about skipping the download part if they intend to use those built-in ones.

@frankcalise
Copy link
Contributor

@lodev09 ohh I see, ok that's great! Do you think it's worth adding a note that if the reader was just looking to enhance the Icon component's registry to @expo/vector-icons that's doable already if they follow that doc page?

This way there is the distinction of why this recipe is different from that

@lodev09
Copy link
Author

lodev09 commented May 8, 2024

@frankcalise done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipe for font icons
3 participants