-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recipes): Custom Vector Icons #108
base: main
Are you sure you want to change the base?
Conversation
@lodev09 Sorry this sat for so long! I'm going to take a look at it this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lodev09 the content looks great! I was able to get it working pretty quickly with the instructions. I just left some comments to bring the markdown styles in line with other recipes, as well as our updated use of CNG
workflow instead of Prebuild
for expo! Thanks for the submission!
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
Co-authored-by: Daniel Edwards <cdaniel.edwards@gmail.com>
@cdanwards done.. Thanks so much! |
Thanks for the contribution! Curious, could we utilize something like this for the font loading rather than downloading font files? Thoughts? https://github.com/expo/examples/blob/master/with-router-menus/src/app/_layout.tsx#L14-L17 |
@frankcalise for sure. The recipe shows downloading these fonts because it's from FontAwesome 6 which is not provided by expo vector icons (since this is a pro version). When using those free ones, it should work as-is following their instruction |
I could add a note in the recipe about skipping the download part if they intend to use those built-in ones. |
@lodev09 ohh I see, ok that's great! Do you think it's worth adding a note that if the reader was just looking to enhance the Icon component's registry to This way there is the distinction of why this recipe is different from that |
@frankcalise done |
@expo/vector-icons
Feel free to edit flow, copy, etc.