Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): better support for yarn 2+ #2684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): better support for yarn 2+ #2684

wants to merge 1 commit into from

Conversation

frankcalise
Copy link
Contributor

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

@frankcalise frankcalise self-assigned this May 10, 2024
@morganick
Copy link
Contributor

@frankcalise changes look fine. Do you have an easy way to test this? The only way I could think of doing it is to create a monorepo structure so that I could preset yarn v4 and then ignite the app inside of it.

@morganick
Copy link
Contributor

Been using corepack for yarn which is on a per project basis. 🤔 Guess I could install yarn 4 globally. Monorepo yarn install works. (There are other ignite complications, but yarn install completes successfully.)

I'll give that a go when I circle back around to this.

morganick
morganick approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Yarn 3.4.1 with corepack. I didn't realize I had yarn installed with homebrew as well 🤦 . Took me a bit longer to review as I kept running into build issues not related to this change:

facebook/react-native#43285

@jamonholmgren
Copy link
Member

Do we have any support to move the recommended package manager off of yarn 1 and to something else? (bun, pnpm, yarn 3+, etc?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganick morganick morganick approved these changes

Assignees

@frankcalise frankcalise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'metro-cache' when initiating the new ignite project
3 participants
@frankcalise @morganick @jamonholmgren