Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): better support for yarn 2+ #2684

Merged
merged 2 commits into from
May 29, 2024
Merged

fix(cli): better support for yarn 2+ #2684

merged 2 commits into from
May 29, 2024

Conversation

frankcalise
Copy link
Contributor

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

@frankcalise frankcalise self-assigned this May 10, 2024
@morganick
Copy link
Contributor

@frankcalise changes look fine. Do you have an easy way to test this? The only way I could think of doing it is to create a monorepo structure so that I could preset yarn v4 and then ignite the app inside of it.

@morganick
Copy link
Contributor

Been using corepack for yarn which is on a per project basis. 🤔 Guess I could install yarn 4 globally. Monorepo yarn install works. (There are other ignite complications, but yarn install completes successfully.)

I'll give that a go when I circle back around to this.

Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Yarn 3.4.1 with corepack. I didn't realize I had yarn installed with homebrew as well 🤦 . Took me a bit longer to review as I kept running into build issues not related to this change:

facebook/react-native#43285

@jamonholmgren
Copy link
Member

Do we have any support to move the recommended package manager off of yarn 1 and to something else? (bun, pnpm, yarn 3+, etc?)

@frankcalise frankcalise merged commit e38a02c into master May 29, 2024
1 check passed
@frankcalise frankcalise deleted the fix/2670 branch May 29, 2024 14:25
infinitered-circleci pushed a commit that referenced this pull request May 29, 2024
# [9.7.0](v9.6.3...v9.7.0) (2024-05-29)

### Bug Fixes

* **boilerplate:** fix deep link not working with navigation persist ([#2679](#2679) by [@vanenshi](https://github.com/vanenshi)) ([a0cd8ce](a0cd8ce))
* **cli:** better support for yarn 2+ ([#2684](#2684) by [@frankcalise](https://github.com/frankcalise) and [@morganick](https://github.com/morganick)) ([e38a02c](e38a02c))
* **metro:** Add support for cjs extension in metro.config.js ([#2689](#2689) by [@jamonholmgren](https://github.com/jamonholmgren)) ([7544fac](7544fac))

### Features

* **boilerplate:** upgrade to Expo SDK 51 ([#2683](#2683) by [@frankcalise](https://github.com/frankcalise)) ([e0f3aa8](e0f3aa8)), closes [#2692](#2692)
@infinitered-circleci
Copy link

🎉 This PR is included in version 9.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'metro-cache' when initiating the new ignite project
4 participants