Improve CI test job speed #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, CI seems to be taking between 5:00-6:30 minutes for most Maverick PRs
CI job of most recent commit shaves about minute off the CI suite
|
|
Last test is the longest out of all the chunks. Thinking of ways to break these up, since the generator file creation may mess with the linting/format/compile checks
|
joshuayoes
force-pushed
the
feat/ci-speed
branch
from
89a54c7
to
1b88c76
Compare
This could not be done in package.json :(
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
joshuayoes
commented
Sep 6, 2022
|
Looking good! https://app.circleci.com/pipelines/github/infinitered/ignite/1764/workflows/59bcfd0f-6cdb-41d4-85a0-ba2e4d11282e/jobs/2318
See my comments for the changes that made a difference |
jamonholmgren
approved these changes
Sep 6, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Problem
Currently, many test jobs on PRs are hitting the 5 minute limit in CircleCI, and failing. We need to speed up the test
Solution
Break up longest running test,
test/vanilla/ignite-new.test.ts, into a series of smaller tests that can be run in parallel