Remove MobX-State-Tree flag for non-demo projects #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcalise
reviewed
Feb 21, 2024
| // TODO: full dryRun support | ||
|
|
||
| p() | ||
| p(`Removing MobX-State-Tree code from '${TARGET_DIR}'${dryRun ? " (dry run)" : ""}`) |
There was a problem hiding this comment.
What about a try/catch here and if running into any issues, let's warn the user the automated removal could not be completed and refer them to the recipe to do so manually?
* feat: cng ftw * fix(babel-config): simplify plugins with SDK 50 * fix(boilerplate): remove unused eslint pkgs * fix(cli): reword workflow question * fix(cli): remove unnecessary warning
|
@Jpoliachik can you target this against |
* feat(boilerplate): mmkv in over async storage * fix(cli): remove async storage new arch specifics * test(boilerplate): mmkv clean up * fix(boilerplate): storage.load with just a string * test(boilerplate): storage test types
|
@frankcalise sure thing, I'll work on this early next week 👍 |
# Conflicts: # boilerplate/app/devtools/ReactotronConfig.ts # src/commands/new.ts
Jpoliachik
changed the title
Jpoliachik
commented
May 9, 2024
| @@ -63,6 +63,7 @@ export const useInitialRootStore = (callback?: () => void | Promise<void>) => { | |||
|
|
|||
| // reactotron integration with the MST root store (DEV only) | |||
| if (__DEV__) { | |||
| // @ts-ignore | |||
| console.tron.trackMstNode(rootStore) | |||
There was a problem hiding this comment.
not sure why this wasn't needed before, but I was getting typescript errors without.
Jpoliachik
commented
May 9, 2024
| result = sanitize(result) | ||
| } else { | ||
| result = updateFile(result, markupPrefix) | ||
| result = sanitize(result) |
There was a problem hiding this comment.
I don't know if this extra sanitize() was happening before - what behavior do we want here, I assumed we'd always want to get rid of all the markup regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for removing MobX-State-Tree code from a non-demo project.
Retargeted to v10 branch.
Changes:
// @mstinline comments, similar to how demo code removal worksdemo.tsremoval logic into more genericmarkup.tsto be shared with@mstcomment types too, and make it easy to add additional other types in the future too.replace-next-linemarkup command type, to help swap out lines of code easily without hot patching in scripts (keeps code replacements inline next to other code)TODOs:
(I'll also add some additional screenshots & videos for testing proof soon)