fix: notification rules with the same name #23925
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API allows to create notification rules with the same name. This PR assumes that notification rules should have unique names and current behavior is a bug.
The fix includes changes in
pkger
. With the attached template, the diff output ofinflux apply --host http://localhost:8086 -f issue23781.yaml
is correct when re-demploy is attempted (this is tested incmd/influxd/launcher/pkger_test.go
):issue23781.yaml