Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replications - Close Idle TCP Connections #23997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suitableZebraCaller
Copy link
Contributor

@suitableZebraCaller suitableZebraCaller commented Dec 20, 2022

Required checklist

  • Signed CLA (if not already signed)

Description

1-3 sentences describing the PR (or link to well written issue)
Attempts to fix: #23996
Closes any Idle TCP connections after a write is called.

Context

Why was this added? What value does it add? What are risks/best practices?
This will prevent any reaching the OS file descriptor limit by closing any TCP connections which are idle especially when transferring large amounts of data to a remote database.

Severity (delete section if not relevant)

i.e., ("recommend to upgrade immediately", "upgrade at your leisure", etc.)

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication: Too many open files
1 participant