Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return MergeIterator.Close errors #24975

Merged
merged 3 commits into from May 13, 2024
Merged

fix: return MergeIterator.Close errors #24975

merged 3 commits into from May 13, 2024
+20 −12

Conversation

davidby-influx
Copy link
Contributor

Return any errors from closing a
MergeIterator

@davidby-influx davidby-influx self-assigned this May 8, 2024
@davidby-influx davidby-influx marked this pull request as draft May 8, 2024 19:41
@davidby-influx davidby-influx removed the request for review from gwossum May 8, 2024 19:42
@davidby-influx davidby-influx marked this pull request as ready for review May 8, 2024 20:17
This was referenced May 8, 2024
Closed
Closed
gwossum
gwossum approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@gwossum gwossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidby-influx davidby-influx merged commit 5fda409 into master-1.x May 13, 2024
9 checks passed
@davidby-influx davidby-influx deleted the DSB_iterator_close branch May 13, 2024 22:11
davidby-influx added a commit that referenced this pull request May 13, 2024
@davidby-influx
fix: return MergeIterator.Close errors (#24975)
bbd16f1 
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24976
davidby-influx added a commit that referenced this pull request May 13, 2024
@davidby-influx
fix: return MergeIterator.Close errors (#24975)
286acb6 
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977
davidby-influx added a commit that referenced this pull request May 13, 2024
@davidby-influx
fix: return MergeIterator.Close errors (#24975) (#24996)
3edc22f 
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24976
davidby-influx added a commit that referenced this pull request May 14, 2024
@davidby-influx
fix: return MergeIterator.Close errors (#24975) (#24997)
a97566b 
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977
davidby-influx added a commit that referenced this pull request May 14, 2024
@davidby-influx
fix: return MergeIterator.Close errors (#24975) (#24997)
b2294d2 
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977

(cherry picked from commit a97566b)

closes #24978
davidby-influx added a commit that referenced this pull request May 14, 2024
@davidby-influx
fix: return MergeIterator.Close errors (#24975) (#24997) (#24998)
00b6888 
Ensure that errors from closing the
iterators underneath a MergeIterator
are returned up the stack.

(cherry picked from commit 5fda409)

closes #24977

(cherry picked from commit a97566b)

closes #24978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwossum gwossum gwossum approved these changes

Assignees

@davidby-influx davidby-influx

Labels
1.x area/queries kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidby-influx @gwossum