feat: add SystemSchemaProvider to QueryExecutor #24990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shell for the `system` table provider was added to the QueryExecutorImpl which currently does not do anything, but will enable us to tie the different system table providers into it. The QueryLog was elevated from the `Database`, i.e., namespace provider, to the QueryExecutorImpl, so that it lives accross queries.
hiltontj
commented
May 13, 2024
| @@ -486,7 +495,6 @@ impl<B: WriteBuffer> QueryTable<B> { | |||
| filters: &[Expr], | |||
| _limit: Option<usize>, | |||
| ) -> Result<Vec<Arc<dyn QueryChunk>>, DataFusionError> { | |||
| // TODO - this is only pulling from write buffer, and not parquet? | |||
There was a problem hiding this comment.
This comment seems irrelevant, so I removed it.
pauldix
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shell for the
systemtable provider was added to theQueryExecutorImplwhich currently does not do anything, but will enable us to tie the different system table providers into it. For example, see the follow up PR that adds thesystem.queriestable: #24992One notable change in this PR was the elevation of the
QueryLogfrom theDatabase, i.e., namespace provider, to theQueryExecutorImpl, so that it lives across queries.Closes #24986