Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.cloudwatch): Option to produce dense metrics #15317

Merged
merged 2 commits into from May 15, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented May 7, 2024

Summary

Introduces a new config option called metric_format to the cloudwatch plugin to produce metrics in either sparse (default) or dense metric format. Sparse produces unique field names for every AWS Metric name + statistic (e.g. latency_avg, latency_sum, etc.), while dense will make the AWS metric name a tag (e.g. latency) and use fields for the various statisitics (e.g. avg, sum).

Checklist

  • No AI generated code was used in this PR

@powersj powersj self-assigned this May 7, 2024
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 7, 2024
@powersj powersj marked this pull request as draft May 7, 2024 14:51
@influxdata influxdata deleted a comment from telegraf-tiger bot May 7, 2024
@powersj powersj marked this pull request as ready for review May 7, 2024 16:36
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 7, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.10 % for linux amd64 (new size: 239.0 MB, nightly size 236.4 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj assigned DStrand1 and srebhan and unassigned powersj May 13, 2024
@powersj
Copy link
Contributor Author

powersj commented May 13, 2024

@DStrand1, @srebhan please review, but do not merge till we get final feedback.

@DStrand1 DStrand1 removed their assignment May 13, 2024
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @powersj! Will reassign to you, so merge whenever you feel it's ready...

@srebhan srebhan assigned powersj and unassigned srebhan May 14, 2024
@powersj powersj merged commit 1a00a48 into influxdata:master May 15, 2024
31 checks passed
@powersj powersj deleted the fix/cloudwatch-metrics branch May 15, 2024 16:11
@github-actions github-actions bot added this to the v1.30.3 milestone May 15, 2024
powersj added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants