Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.internet_speed): support packet loss #15329

Merged
merged 8 commits into from May 10, 2024
Merged

feat(inputs.internet_speed): support packet loss #15329

merged 8 commits into from May 10, 2024

Conversation

r3inbowari
Copy link
Contributor

@r3inbowari r3inbowari commented May 9, 2024 •
edited

Summary

  1. Bump to new version to improve test precision and fix bugs.
  2. Support packet_loss field.

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 9, 2024
powersj
powersj reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @r3inbowari thanks for the PR and updates, one question from my side in the docs, otherwise looks good. Thanks again!

plugins/inputs/internet_speed/README.md Outdated Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 9, 2024
srebhan
srebhan reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r3inbowari thanks for your contribution! I do have some comments in the code, mostly on error checking...

plugins/inputs/internet_speed/internet_speed.go Outdated Show resolved Hide resolved
plugins/inputs/internet_speed/internet_speed.go Outdated Show resolved Hide resolved
srebhan
srebhan approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r3inbowari!

@srebhan
Copy link
Contributor

srebhan commented May 10, 2024

@powersj assigning it back to you for checking the code change...

@srebhan srebhan assigned powersj and unassigned srebhan May 10, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit afd7f93 into influxdata:master May 10, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 10, 2024
@powersj powersj mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r3inbowari @srebhan @powersj @DStrand1