Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed the entire node build into the final image #852

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

make-github-pseudonymous-again
Copy link
Contributor

Not sure if this is necessary. Requires some research on the proper way of installing Node.js. Even if we have to include the lib and include directories, it would only add ~40MB to the image. Compare this to ~80MB for bin which is already included.

@make-github-pseudonymous-again make-github-pseudonymous-again added deploy This issue is about deployment docker This has to do with docker images and containers labels Apr 8, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as draft April 8, 2024 21:07
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.86%. Comparing base (d539968) to head (98de8fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   65.86%   65.86%           
=======================================
  Files         715      715           
  Lines        9893     9893           
  Branches     1346     1346           
=======================================
  Hits         6516     6516           
  Misses       2919     2919           
  Partials      458      458           
Flag Coverage Δ
client 46.23% <ø> (ø)
server 61.87% <ø> (ø)
test 71.97% <ø> (ø)
test-app 53.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again
Copy link
Contributor Author

Also, followed https://guide.meteor.com/using-node-v14.21.4#installing-node-in-linux for the proper way of defining $NODE_PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy This issue is about deployment docker This has to do with docker images and containers
Development

Successfully merging this pull request may close these issues.

None yet

1 participant