Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish ci:build, ci:build:image, and ci:build:compose (bis) #919

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

make-github-pseudonymous-again
Copy link
Contributor

  • Cleanup:
    • Remove unnecessary steps: repeated docker container logs, docker ps -a, ls/cat, ...
    • Add name with emoji to each step.
    • Harmonize docker container names.
  • Strengthen:
    • Check Node and NPM's version in all workflows.
    • Check that server is properly killed by SIGTERM in ci:build test job.
  • Research:
    • Check if setting up buildx allows to docker run to use --health-start-interval.
  • Refactor actions:

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.48%. Comparing base (a3dc94b) to head (c084d10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   64.48%   64.48%           
=======================================
  Files         703      703           
  Lines        9705     9705           
  Branches     1335     1335           
=======================================
  Hits         6258     6258           
  Misses       3003     3003           
  Partials      444      444           
Flag Coverage Δ
test 69.80% <ø> (ø)
test-app 53.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again
Copy link
Contributor Author

The factoring out of storage.yaml out of compose.yaml should be moved to a separate PR as this should already work without additional research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant