-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pdfjs-dist
to v3.5
#944
Draft
make-github-pseudonymous-again
wants to merge
2
commits into
main
Choose a base branch
from
deps-upgrade-pdfjs-dist-v3.5-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade pdfjs-dist
to v3.5
#944
make-github-pseudonymous-again
wants to merge
2
commits into
main
from
deps-upgrade-pdfjs-dist-v3.5-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-github-pseudonymous-again
temporarily deployed
to
Snyk
May 14, 2024 01:21
— with
GitHub Actions
Inactive
make-github-pseudonymous-again
added
technology/pdf
This has to do with leveraging the portable document format.
dependencies
Pull requests that update a dependency file
deps
This issue has to do with dependencies
labels
May 14, 2024
make-github-pseudonymous-again
force-pushed
the
deps-upgrade-pdfjs-dist-v3.5-1
branch
from
May 14, 2024 02:35
2da5999
to
2fa82a8
Compare
make-github-pseudonymous-again
temporarily deployed
to
Snyk
May 14, 2024 02:35
— with
GitHub Actions
Inactive
Should try to see if node module recompilation helps. |
make-github-pseudonymous-again
temporarily deployed
to
Snyk
May 14, 2024 02:57
— with
GitHub Actions
Inactive
With recompilation enabled, it complains about private class methods: Errors prevented bundling:
While building for os.linux.x86_64:
node_modules/pdfjs-dist/build/pdf.js:
/home/runner/work/patients/patients/node_modules/pdfjs-dist/build/pdf.js: Class
private methods are not enabled. Please add
`@babel/plugin-proposal-private-methods` to your configuration.
1551 | return success;
1552 | }
> 1553 | #tryCleanup(delayed = false) {
| ^
1554 | this.#abortDelayedCleanup();
1555 | if (!this.#pendingCleanup) {
1556 | return false;
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! patients@ build: `meteor build "../dist" "--directory" "--server-only" "--architecture" "os.linux.x86_64"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the patients@ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2024-05-14T02_59_43_078Z-debug.log |
make-github-pseudonymous-again
force-pushed
the
deps-upgrade-pdfjs-dist-v3.5-1
branch
from
May 14, 2024 09:31
44479a6
to
df442ed
Compare
make-github-pseudonymous-again
temporarily deployed
to
Snyk
May 14, 2024 09:31
— with
GitHub Actions
Inactive
make-github-pseudonymous-again
added
needs-dependency-upgrade
Solving this issue requires upgrading at least one dependency
waiting-for-upstream
This issues needs an update from upstream before it can be resolved.
and removed
needs-dependency-upgrade
Solving this issue requires upgrading at least one dependency
labels
May 22, 2024
make-github-pseudonymous-again
removed this from Waiting
in Deps upgrade sprint April 2024
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
deps
This issue has to do with dependencies
technology/pdf
This has to do with leveraging the portable document format.
waiting-for-upstream
This issues needs an update from upstream before it can be resolved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of
pdfjs-dist
that fails because ofSyntaxError: Unexpected token '||='
: