Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-core): Type mixin props as PropertyDeclarations (fixes: #1768) #1794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

riovir
Copy link
Contributor

@riovir riovir commented Oct 17, 2022

What I did

  1. Exposed the PropertyDeclarations from lit through @lion/core
  2. Used the PropertyDeclarations in the form-core package mixins: strictly speaking the [FormControlMixin] Type error when extending with extra property #1768 issue is only concerned with the FormControlMixin. That said, updated the other mixins in the form-core for consistency's sake.

These changes should prevent type errors experienced by devs who extend form-related components with additional properties.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: 93ef266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lion/core Patch
@lion/form-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gerjanvangeest
Copy link
Member

Hi @riovir, thanks for the PR, sorry i didn't review it faster.
Could you rebase the changes, then i will approve it.

@gerjanvangeest gerjanvangeest added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2023
@gerjanvangeest
Copy link
Member

This PR still needs some attention, maybe we can bring it back to live and finalise it soon!
Anybody lending a hand, feel free 💪!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants