Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slotmixin): Now throws shadowRoot not found in case of shadowRoot… #2291

Merged
merged 5 commits into from
May 21, 2024

Conversation

Dozom
Copy link
Contributor

@Dozom Dozom commented May 17, 2024

… equals to null

What I did

  1. I throw an error if shadowRoot was not found.

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 69150cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

Co-authored-by: Thijs Louisse <t_louisse@hotmail.com>
@Dozom
Copy link
Contributor Author

Dozom commented May 17, 2024

Hello @tlouisse! It was my first contribution to open source,

  1. When do I have to execute npm run changelog, after pulling the changes or before?
  2. How can I add the changelog?

Actual step (local fork):
image

It created a .changeset/odd-poets-grow.md
with the following content,

'@lion/ui': major

fix(slotmixin): Now prints a console error when shadowRoot is not found

What is this used for?

Thank's for the answer!

@tlouisse
Copy link
Member

tlouisse commented May 20, 2024

Hi @Dozom

  1. When do I have to execute npm run changelog, after pulling the changes or before?

It's a good practice to attach a changeset entry to a commit(npm run changeset writes an md file to the .changesets folder).

  1. How can I add the changelog?

This is done automatically in a separate pipeline (@changeset/cli generates the changelog based on the changeset files: https://github.com/changesets/changesets?tab=readme-ov-file)

@Dozom
Copy link
Contributor Author

Dozom commented May 20, 2024

Hi @tlouisse
I added the changeset entry, is it correct?
On the other hand, thank's for documentation I really appreciated. 😄

@tlouisse tlouisse merged commit 08d13e1 into ing-bank:master May 21, 2024
7 checks passed
@tlouisse
Copy link
Member

Hi @tlouisse I added the changeset entry, is it correct? On the other hand, thank's for documentation I really appreciated. 😄

Yes, looks good. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants