Add new stack top as an additional parameter for onItemPop

inikulin · Feb 5, 2022 · bc0a1f7 · bc0a1f7
1 parent 8649dbe
commit bc0a1f7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/parse5/lib/parser/index.test.ts b/packages/parse5/lib/parser/index.test.ts
@@ -122,7 +122,7 @@ describe('parser', () => {
             expect(onItemPush).toHaveBeenNthCalledWith(3, bodyElement);
             expect(onItemPush).toHaveBeenLastCalledWith(bodyElement.childNodes[1]);
             expect(onItemPop).toHaveBeenCalledTimes(2);
-            expect(onItemPop).toHaveBeenLastCalledWith(bodyElement.childNodes[0]);
+            expect(onItemPop).toHaveBeenLastCalledWith(bodyElement.childNodes[0], bodyElement);
         });
     });
 });
diff --git a/packages/parse5/lib/parser/index.ts b/packages/parse5/lib/parser/index.ts
@@ -326,7 +326,7 @@ export class Parser<T extends TreeAdapterTypeMap> {
             this._setEndLocation(node, this.currentToken!);
         }
 
-        this.treeAdapter.onItemPop?.(node);
+        this.treeAdapter.onItemPop?.(node, this.openElements.current);
 
         if (isTop) {
             let current;

diff --git a/packages/parse5/lib/tree-adapters/interface.ts b/packages/parse5/lib/tree-adapters/interface.ts
@@ -292,5 +292,5 @@ export interface TreeAdapter<T extends TreeAdapterTypeMap = TreeAdapterTypeMap>
      *
      * @param item The element being popped.
      */
-    onItemPop?: (item: T['element']) => void;
+    onItemPop?: (item: T['element'], newTop: T['parentNode']) => void;
 }