Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): Set endTag loc for mixed-case foreign elements #353

Merged
merged 3 commits into from Feb 15, 2022

Conversation

pmdartus
Copy link
Contributor

Update setEndLocation logic to account for tag name with uppercase.
Fixes #352.

@fb55 fb55 changed the title Handle endTag location for elements with uppercased tag name fix(parser): Set endTag loc for mixed-case foreign elements Feb 15, 2022
@fb55 fb55 merged commit 72a98ac into inikulin:master Feb 15, 2022
@fb55
Copy link
Collaborator

fb55 commented Feb 15, 2022

Thanks a lot @pmdartus!

fb55 added a commit to parse5/parse5-fork that referenced this pull request Mar 2, 2022
…in#353)

Co-authored-by: Felix Böhm <188768+fb55@users.noreply.github.com>
@pmdartus pmdartus deleted the pmdartus/uppercase-endTag branch June 19, 2022 06:44
jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
…in#353)

Co-authored-by: Felix Böhm <188768+fb55@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing endTag source location information on SVG elements with uppercased tag name
2 participants