fix(parser): Set endTag loc for mixed-case foreign elements (inikul…

…in#353) Co-authored-by: Felix Böhm <188768+fb55@users.noreply.github.com>
parse5 · Mar 2, 2022 · cb2265d · cb2265d
1 parent 8b96699
commit cb2265d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/parse5/lib/parser/index.ts b/packages/parse5/lib/parser/index.ts
@@ -3783,7 +3783,11 @@ function endTagInForeignContent<T extends TreeAdapterTypeMap>(p: Parser<T>, toke
             break;
         }
 
-        if (p.treeAdapter.getTagName(element).toLowerCase() === token.tagName) {
+        const tagName = p.treeAdapter.getTagName(element);
+
+        if (tagName.toLowerCase() === token.tagName) {
+            //NOTE: update token tag name for `_setEndLocation`.
+            token.tagName = tagName;
             p.openElements.shortenToLength(i);
             break;
         }

diff --git a/packages/parse5/lib/parser/parser-location-info.test.ts b/packages/parse5/lib/parser/parser-location-info.test.ts
@@ -132,6 +132,26 @@ generateTestsForEachTreeAdapter('location-info-parser', (treeAdapter) => {
 
         assert.ok(!location.endTag);
     });
+
+    test('Regression - location.endTag should be available adjusted SVG elements (GH-352)', () => {
+        const html = '<svg><foreignObject></foreignObject></svg>';
+
+        const opts = {
+            treeAdapter,
+            sourceCodeLocationInfo: true,
+        };
+
+        const fragment = parse5.parseFragment(html, opts);
+        const svg = treeAdapter.getChildNodes(fragment)[0];
+        const foreignObject = treeAdapter.getChildNodes(svg)[0];
+        const location = treeAdapter.getNodeSourceCodeLocation(foreignObject);
+
+        assert.ok(location && location.startTag && location.endTag);
+        assert.strictEqual(
+            html.slice(location.startTag.startOffset, location.endTag.endOffset),
+            '<foreignObject></foreignObject>'
+        );
+    });
 });
 
 describe('location-info-parser', () => {