Refactor & improve serializer #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 18, 2022
and improve the options type
Fixes inikulin#230, inikulin#378 Uses the test case from inikulin#378, by @joeldenning Co-Authored-By: Joel Denning <5524384+joeldenning@users.noreply.github.com>
Before this, passing a `template` tag to `serialize` would result in an empty string.
fb55
force-pushed
the
refactor/serializer
branch
from
b358353
to
a6f4b62
Compare
fb55
added a commit
to parse5/parse5-fork
that referenced
this pull request
Mar 2, 2022
Co-authored-by: Joel Denning <5524384+joeldenning@users.noreply.github.com>
|
|
|
I am trying to make a release happen – should only be another week or two. |
|
@fb55 Maybe good to create a (pinned) issue tracking it and what needs to be done? |
|
@wooorm I've done a push to tackle the remaining items I want to see, and have opened PRs for them. Once these are concluded, I am ready to get a release out. |
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Co-authored-by: Joel Denning <5524384+joeldenning@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the serializer by removing the wrapping class, fixes mixed content (#333), adds the scripting flag (#332), and adds a
serializeOutermethod (#230, #378). Also fixes passing a<template>element toserializeresulting in an empty string.The
parse5-serializer-streammodule should be deprecated after these changes.