Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serializeOuter function. Resolves #230. #378

Closed
wants to merge 1 commit into from

Conversation

joeldenning
Copy link
Contributor

See #230. This is an alternative to #347.

fb55 added a commit to parse5/parse5-fork that referenced this pull request Jan 18, 2022
Fixes inikulin#230, inikulin#378

Uses the test case from inikulin#378, by @joeldenning

Co-Authored-By: Joel Denning <5524384+joeldenning@users.noreply.github.com>
fb55 added a commit to parse5/parse5-fork that referenced this pull request Feb 7, 2022
Fixes inikulin#230, inikulin#378

Uses the test case from inikulin#378, by @joeldenning

Co-Authored-By: Joel Denning <5524384+joeldenning@users.noreply.github.com>
@fb55
Copy link
Collaborator

fb55 commented Feb 15, 2022

I have done a bigger refactor of the serialisation code in #383. This added a serializeOuter method, and includes the test case from this PR (while naming you as a co-author). Thanks a lot @joeldenning for getting this started!

@fb55 fb55 closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants