Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): Consume tokenizer events #419

Merged
merged 6 commits into from Mar 2, 2022
Merged

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented Feb 27, 2022

Fixes #403

Final PR for #403. Now that everything is prepared, we can switch the parser to consuming tokenizer events.

This required an update for the parser feedback test generation script, which now has to consume events as well.

@fb55
Copy link
Collaborator Author

fb55 commented Feb 27, 2022

master is currently broken due to a misalignment of the previous two commits. This PR will resolve the issue.

@@ -11,22 +10,17 @@ interface LocationInfoTestCase {
}

/** Receives events and immediately compares them against the expected values. */
class LocationInfoHandler extends SinglePathHandler {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SinglePathHandler was merged into LocationInfoHandler.

@fb55 fb55 merged commit 1615a5e into master Mar 2, 2022
@fb55 fb55 deleted the parser-event-consumer branch March 2, 2022 10:53
jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Replace the token queue with an event-handler system
1 participant