Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make location info parser tests work #440

Merged
merged 5 commits into from
Mar 7, 2022
Merged

refactor: Make location info parser tests work #440

merged 5 commits into from
Mar 7, 2022

Commits on Mar 7, 2022

  1. Serialize any kind of node in serializeOuter

    @fb55
    fb55 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    55d414b View commit details
    Browse the repository at this point in the history

  2. Remove null values from document types 

    BREAKING: The serialization of document types stored in the htmlparser2 adapter now no longer has an empty trailing string. Ie. `<!DOCTYPE html "">` is now `<!DOCTYPE html>`.
    @fb55
    fb55 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    38639f3 View commit details
    Browse the repository at this point in the history

  3. Make location info parser tests work 

    For some reason, we were escaping the data before. That meant we would only assert once that the received string matched the input.

Now, we properly walk the tree (depth first, from the deepest node), and test nodes along the way.

Requires #436
    @fb55
    fb55 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    529b6ad View commit details
    Browse the repository at this point in the history

  4. Return an empty string for unknown nodes 

    Otherwise this would be a breaking change
    @fb55
    fb55 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    cc987e6 View commit details
    Browse the repository at this point in the history

  5. Remove else after return in serializeNode

    @fb55
    fb55 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    d9865d3 View commit details
    Browse the repository at this point in the history