chore(test): Use finished to check streams
#462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node's promise `finished` function is only available in Node 16.
This reverts commit b236db5.
fb55
commented
Mar 17, 2022
| @@ -18,18 +18,16 @@ async function main() { | |||
| maxMemUsage = Math.max(maxMemUsage, stats.used_heap_size); | |||
| }); | |||
|
|
|||
| const statsPromise = new Promise((resolve) => memwatch.once('stats', resolve)); | |||
There was a problem hiding this comment.
This event was updated to use the promise constructor, which allowed us to get rid of promisify-event.
| @@ -21,7 +22,7 @@ global.upstreamParser = parse5Upstream; | |||
| global.hugePage = readFileSync(hugePagePath).toString(); | |||
|
|
|||
| // Micro data | |||
| global.microTests = loadTreeConstructionTestData([treeConstructionPath], treeAdapters.default) | |||
| global.microTests = loadTreeConstructionTestData(treeConstructionPath, treeAdapters.default) | |||
There was a problem hiding this comment.
The perf benchmark was broken, as I forgot to update this call site to loadTreeConstructionTestData when changing the argument to a URL.
fb55
changed the title
finished to check streamsfinished to check streams
wooorm
reviewed
Mar 22, 2022
No worries — as this only relates to tests, I'm feeling quite confident in the changes and will go ahead with things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
finishevent doesn't actually fire every time a stream ends. This was already discovered in #432. This PR cleans up all other call locations.Also switches us to using promises instead of callbacks for these tests. This has the advantage that errors will actually be reported by the test runner, instead of being uncaught inside a hanging test.