Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add coverage reporting #515

Merged
merged 3 commits into from Apr 21, 2022
Merged

chore(ci): Add coverage reporting #515

merged 3 commits into from Apr 21, 2022

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented Apr 20, 2022

Fixes #211

.github/workflows/nodejs-test.yml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Copy link
Collaborator

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

is there any easy way to get to the right coveralls page? maybe we can add a badge or something? or make CI output it?

@fb55
Copy link
Collaborator Author

fb55 commented Apr 21, 2022

Coveralls should write the coverage as a check for each PR, and error if it is reduced. My guess is that the lack of a baseline for the master branch makes coveralls skip writing the check.

@fb55 fb55 merged commit 1405ca0 into master Apr 21, 2022
@fb55 fb55 deleted the coverage branch April 21, 2022 13:05
@fb55
Copy link
Collaborator Author

fb55 commented Apr 21, 2022

I have added a badge in #517

jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code coverage metrics
3 participants