Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Have </button> close <p> #534

Merged
merged 1 commit into from May 9, 2022
Merged

fix(parser): Have </button> close <p> #534

merged 1 commit into from May 9, 2022

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented May 8, 2022

Fixes #533

A PR with a test was opened at html5lib/html5lib-tests#146

wooorm
wooorm reviewed May 8, 2022
View reviewed changes
Copy link
Collaborator

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a test? If it isn’t pulled in already/soon? Otherwise, guessing this does the trick!

@fb55
Copy link
Collaborator Author

fb55 commented May 9, 2022

Thanks for having a look!

html5lib/html5lib-tests#146 was merged, going ahead with this :)

@fb55 fb55 merged commit 84e52f5 into master May 9, 2022
@fb55 fb55 deleted the button-closes-p branch May 9, 2022 08:07
jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
@fb55 @jmbpwtw
fix(parser): Have </button> close <p> (inikulin#534)
f0aaa71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug with parsing <button><p></button>x
2 participants
@fb55 @wooorm