Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Several small changes #547

Merged
merged 6 commits into from May 20, 2022
Merged

refactor: Several small changes #547

merged 6 commits into from May 20, 2022

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented May 20, 2022

This is a bundle of several small changes that came up with html5lib/html5lib-tests#147

Overview over the changes:

  • reconsumeInState will now call the state directly, instead of retreating.
  • We knew in several places that we wanted to get to the template end logic of the in head insertion mode. By factoring out that insertion mode, we can skip some steps.
  • Added a test for serialising unknown nodes (which should lead to an empty string)
  • Test indices were previously global, which resulted in ignores failing after an unrelated test was added. Now, test indices are local.
  • Simplify a conditional statement to a ternary (following the Principle of Most Restrictive Production)

@fb55 fb55 merged commit edb85df into master May 20, 2022
@fb55 fb55 deleted the refactor-tk branch May 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants