feat(parse5): use string types for node names #631
Merged
+12
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially to change
NodeType
into a union, but that doesn't make sense since we wouldn't make use of the type then, we'd just use the string literal types anyway.Nothing references
NodeType
outside the tree adapter and it isn't exported publicly (index.ts
) currently.So instead i just dropped
NodeType
and used a string literal type for each node type.@fb55 what do you think? this matches how it was originally (pre-rewrite) and allows people to create nodes without pulling the (currently not exported afaict) enum in.
if anyone wants the type union, they can do
Node['nodeName']
, which we could alias intoNodeType
if its still of any use