fix(tokenizer): Properly handle CR when peeking #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeking didn't properly support carriage returns, which led the parser to hang in special tags. Fixes #710
wooorm
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Looks good, but the test seems a bit specific to how the tokenizer is implemented. Perhaps a reduced case from the original problem (#710 (comment)) can be added as a test for the parser as a whole?
|
Thanks for the review! I've switched the test to a parser regression test, following the pattern we already had in place for similar issues. |
Merged
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peeking didn't properly support carriage returns, which led the parser to hang in special tags.
Fixes #710