Add Fail handler to executor #1109
Open
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
darwin67
approved these changes
Feb 9, 2024
| @@ -1281,6 +1281,48 @@ func (e *executor) handleAggregatePauses(ctx context.Context, evt event.TrackedE | |||
| return res, goerr | |||
| } | |||
|
|
|||
| func (e *executor) Fail(ctx context.Context, runID ulid.ULID, err error) error { | |||
| s, err := e.sm.Load(ctx, runID) | |||
There was a problem hiding this comment.
the func argument should either be renamed from err of the ones in the function should be renamed based on the warning.
This calls lifecycles after marking a function as failed.
tonyhb
force-pushed
the
chore/fail-handler
branch
from
25ec570
to
4d5af5d
Compare
tonyhb
requested review from
djfarrelly,
goodoldneon and
jpwilliams
as code owners
jpwilliams
reviewed
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This calls lifecycles after marking a function as failed.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines