Clean up initial edge execution path #1158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyhb
requested review from
djfarrelly,
darwin67,
goodoldneon and
jpwilliams
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
goodoldneon
reviewed
Feb 17, 2024
| @@ -578,26 +571,6 @@ func (e *executor) Execute(ctx context.Context, id state.Identifier, item queue. | |||
| // we automatically enqueue all children of the dag from the root node. | |||
| // This can be cleaned up. | |||
There was a problem hiding this comment.
Does the comment need updating?
jpwilliams
reviewed
Feb 19, 2024
Comment on lines
+125
to
+132
| // GetRetries returns the number of retries for the function. | ||
| func (f Function) GetRetries() int { | ||
| // This uses retries in steps; a holdover from when steps were used in our DAG based approach. | ||
| if len(f.Steps) == 0 || f.Steps[0].Retries == nil { | ||
| return consts.DefaultRetryCount | ||
| } | ||
| return *f.Steps[0].Retries | ||
| } |
There was a problem hiding this comment.
Related to the comment on retries -> attempts, it might be better to encapsulate the + 1 inside this function and call it GetAttempts, as we can clean up the retries/attempts mess when we add function.retries in the config. After that:
- If SDK sends
step.retries.attempts(legacy),+ 1 - If SDK sends
function.retries(future), do not+ 1
Co-authored-by: Jack Williams <jack@inngest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some vestiges of our DAG-based days lurking around. This code simplifies the initial executor path, consolidating on the single-step approach we've been rolling with for a couple years — which won't change.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines