Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk cancellation UI #1251

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add bulk cancellation UI #1251

wants to merge 3 commits into from

Conversation

goodoldneon
Copy link
Contributor

⚠️ Depends on https://github.com/inngest/monorepo/pull/2507

Description

Add the new UI for bulk run cancellation, which includes:

  • New nav item (controlled by a feature flag)
  • Cancellation list
  • Cancellation creation button
  • Cancellation creation modal
image

Some other changes:

  • Added a proper generic for the Table component, since any is bad
  • Added className prop to Modal.Body
  • Added className and name props to TimeInput
  • Added disablePasswordManager prop to Input, since 1Password was inserting itself into the modal form

How to review

Checkout the cancellation-gql branch in monorepo to get the necessary backend changes

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Mar 27, 2024 1:04am

Copy link
Collaborator

@darwin67 darwin67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but probably good to have another review from someone more familiar with the UI code as well.

pwManagerProps = {
'data-1p-ignore': 'true', // 1Password
'data-lpignore': 'true', // LastPass
'data-bwignore': 'true', // Bitwarden
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants