Add API for runs v2 list #1345
Merged
Add API for runs v2 list #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwin67
requested review from
tonyhb,
djfarrelly,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
darwin67
changed the title
darwin67
commented
May 15, 2024
| }) | ||
|
|
||
| // TODO: Fix this | ||
| // t.Run("retrieve only failed runs sorted by ended_at", func(t *testing.T) { |
There was a problem hiding this comment.
this test passes when ran within this file, but fails when running the full test suite somehow, so something seems to be interfering with the data when the whole test suite runs.
comment it out for now and address it later.
tonyhb
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add API for new runs feature in Dev Server.
This change implements the following:
Type of change (choose one)
Checklist
Check our Pull Request Guidelines