Set request.Close in httpdriver #925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tonyhb
force-pushed
the
chore/http-logs
branch
from
a1d6a1f
to
1d988bd
Compare
darwin67
approved these changes
Dec 7, 2023
finishing and never be reused
tonyhb
force-pushed
the
chore/http-logs
branch
from
1d988bd
to
141d810
Compare
tonyhb
changed the title
|
@tonyhb is this PR still needed? |
If anything it's a (very minor) net positive, so I'll rebase and merge later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.GetBody could be used in the rare circumstance that an external SDK's ALB redirects to another source while part of the body has been consumed. In this circumstance, we give the Golang HTTP client a method to retrieve a fresh copy of the request body for the next HTTP request.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines