Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes version name in package main file and commit message #123

Closed
wants to merge 1 commit into from

Conversation

luislard
Copy link
Contributor

@luislard luislard commented Apr 16, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #121

What is the current behavior? (You can also link to an open issue here)
Inconsistent version names

What is the new behavior (if this is a feature change)?

  • Version name in commit is fixed
  • Version name in main file is fixed
  • Version name in package.json is fixed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
I will iterate on this, since this is not fixing all the problems.

@luislard
Copy link
Contributor Author

Potentially replaced by #124

@luislard
Copy link
Contributor Author

Superseded by #124

@luislard luislard closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Automatic release provide inconsistent version names to commits and replacements
1 participant