-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade master to Node 8.9.2 #1251
Draft
mirceahasegan
wants to merge
227
commits into
master
Choose a base branch
from
chore/LW-7691-master-merge
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{"local": {"subdir": "packages/cardano-services/config" ,"action": "pull"} ,"remote": {"url": "https://github.com/input-output-hk/cardano-configurations.git" ,"branch": "master" ,"commit": "8a403bb2f"} ,"git-subrepo": {"version": "0.1.0" ,"commit": "???" ,"origin": "???"}}
…chonet-support # Conflicts: # packages/cardano-services/config/.gitrepo # packages/cardano-services/config/network/preview/cardano-node/config.json # packages/cardano-services/config/network/sanchonet/cardano-node/config.json
- So far only `x86_64-linux` works, I’ll fix an `aarch64-linux` version shortly - clone cardano-configurations directly
- use the new custom Ogmios Dockerfile - adds new yarn scripts to start the sanchonet services - generated new fixtures reflecting new cardano tools version - bump cardano-db-sync to use new image registry
Feat/Sanchonet dev env
- reduce block types to bft, ebb and praos - update tx mapper - update OgmiosCardanoNode - update observableChainSync and TxSubmitProvider - ogmios Tip is transformed to SDK Tip Extra scripts have been moved to the scripts field and merged with witness scripts as part of the ogmios 6.0 refactoring: https://github.com/CardanoSolutions/ogmios/blob/master/architectural-decisions/ accepted/017-api-version-6-major-rewrite.md#transaction. Rationale for the removal: #927 (comment) BREAKING CHANGE: update core CardanoNode error types - Removed `OnChainTx` `witness.scripts` and `auxiliaryData.scripts`
Ogmios createInteractionContextWithLogger no longer expects an interaction type.
Avoid "no space left on device" error
…ng-changes Refactor/ogmios 6 breaking changes
…gistration-needs-sig Feat/conway stake key registration needs sig
…error Fix/handle bigint inner error
interactionType no longer exists also, remove an unnecessary eslint-disable
implement it for OgmiosObservableCardanoNode
OgmiosTxSubmitProvider was unreliable as it didn't have any re-connection logic. ObservableCardanoNode already had re-connection logic in-place. Furthermore, this refactor reduces the scope of Ogmios dependency, because ogmios package is no longer Provider-aware. This is a step towards refining this package as a thin wrapper over ogmios client libraries. OgmiosTxSubmitProvider is replaced by a combination of: - ObservableCardanoNode.submitTx - a new NodeTxSubmitProvider implementation that depends on ObservableCardanNode and HandleProvider Note: re-enabling rabbitMqTxSubmitProvider and TxSubmitWorker tests is out of scope of this commit. Those tests were already disabled. This commit modified the test files in order for tests to compile.
…tx-submission fix: resilient ogmios v6 tx submission
This reverts commit eabe8eb.
Moving back to 'DRAFT' state until changes from PR-1222 are integrated here too |
mirceahasegan
force-pushed
the
chore/LW-7691-master-merge
branch
from
May 17, 2024 11:06
ff094e7
to
8d059c2
Compare
This PR will remain in DRAFT state until the changes are thoroughly tested. |
bernokl
temporarily deployed
to
dev-preprod-resync
May 17, 2024 15:24
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgrading to Cardano Node 8.9.2 also requires updating Ogmios to 6+.
Ogmios 6+ is breaking wrt previous versions, but the work to address the breaking changes was already done on the
conway-era
branch.Proposed Solution
Branch fromBranched fromconway-era
:chore/LW-7691-conway-era-variant-for-master-merge
master
intochore/LW-7691-master-merge
. Mergedcomway-era
into it.sanchonet-*
ones.master
ONLY AFTER db-sync migration for the existing deployments is planned and ready to execute.