Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade master to Node 8.9.2 #1251

Draft
wants to merge 227 commits into
base: master
Choose a base branch
from
Draft

Conversation

mirceahasegan
Copy link
Contributor

@mirceahasegan mirceahasegan commented May 7, 2024

Context

Upgrading to Cardano Node 8.9.2 also requires updating Ogmios to 6+.
Ogmios 6+ is breaking wrt previous versions, but the work to address the breaking changes was already done on the conway-era branch.

Proposed Solution

  1. Branch from conway-era: chore/LW-7691-conway-era-variant-for-master-merge Branched from master into chore/LW-7691-master-merge. Merged comway-era into it.
  2. Update to use stable DbSync (13.2.0.2) instead of the sanchonet-* ones.
  3. Adapt to schema changes and stabilise.
  4. Merge to master ONLY AFTER db-sync migration for the existing deployments is planned and ready to execute.

rhyslbw and others added 30 commits September 27, 2023 21:23
{"local":
  {"subdir":  "packages/cardano-services/config"
  ,"action":  "pull"}
,"remote":
  {"url":     "https://github.com/input-output-hk/cardano-configurations.git"
  ,"branch":  "master"
  ,"commit":  "8a403bb2f"}
,"git-subrepo":
  {"version": "0.1.0"
  ,"commit":  "???"
  ,"origin":  "???"}}
…chonet-support

# Conflicts:
#	packages/cardano-services/config/.gitrepo
#	packages/cardano-services/config/network/preview/cardano-node/config.json
#	packages/cardano-services/config/network/sanchonet/cardano-node/config.json
- So far only `x86_64-linux` works, I’ll fix an `aarch64-linux` version shortly
- clone cardano-configurations directly
- use the new custom Ogmios Dockerfile
- adds new yarn scripts to start the sanchonet services
- generated new fixtures reflecting new cardano tools version
- bump cardano-db-sync to use new image registry
- reduce block types to bft, ebb and praos
- update tx mapper
- update OgmiosCardanoNode
- update observableChainSync and TxSubmitProvider
- ogmios Tip is transformed to SDK Tip

Extra scripts have been moved to the scripts field and merged with
witness scripts as part of the ogmios 6.0 refactoring:
https://github.com/CardanoSolutions/ogmios/blob/master/architectural-decisions/
accepted/017-api-version-6-major-rewrite.md#transaction.
Rationale for the removal:
#927 (comment)

BREAKING CHANGE: update core CardanoNode error types
  - Removed `OnChainTx` `witness.scripts` and `auxiliaryData.scripts`
Ogmios createInteractionContextWithLogger no longer expects an
interaction type.
Avoid "no space left on device" error
…ng-changes

Refactor/ogmios 6 breaking changes
…gistration-needs-sig

Feat/conway stake key registration needs sig
interactionType no longer exists

also, remove an unnecessary eslint-disable
implement it for OgmiosObservableCardanoNode
OgmiosTxSubmitProvider was unreliable as it didn't
have any re-connection logic. ObservableCardanoNode
already had re-connection logic in-place.

Furthermore, this refactor reduces the scope of Ogmios
dependency, because ogmios package is no longer Provider-aware.
This is a step towards refining this package as a thin wrapper
over ogmios client libraries.

OgmiosTxSubmitProvider is replaced by a combination of:
- ObservableCardanoNode.submitTx
- a new NodeTxSubmitProvider implementation that depends
  on ObservableCardanNode and HandleProvider

Note: re-enabling rabbitMqTxSubmitProvider and TxSubmitWorker tests
is out of scope of this commit. Those tests were already disabled.
This commit modified the test files in order for tests to compile.
…tx-submission

fix: resilient ogmios v6 tx submission
@mirceahasegan
Copy link
Contributor Author

Moving back to 'DRAFT' state until changes from PR-1222 are integrated here too

@mirceahasegan mirceahasegan marked this pull request as draft May 15, 2024 12:24
@mirceahasegan
Copy link
Contributor Author

mirceahasegan commented May 17, 2024

This PR will remain in DRAFT state until the changes are thoroughly tested.
Reviews are welcome, but not required until the testing is complete, and PR is ready for review.

@bernokl bernokl temporarily deployed to dev-preprod-resync May 17, 2024 15:24 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants