-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove null characters from user-specified strings when storing … #1294
Conversation
|
…nft metadata also add a new chain sync data set in util-dev
e43cf48
to
29a0014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
similarly to #1294, otherProperties are used-specified, and properties can have null characters which cannot be inserted into postgres 'jsonb' column also, generate a new chain sync dataset with a block that has null characters in other properties
similarly to #1294, otherProperties are used-specified, and properties can have null characters which cannot be inserted into postgres 'jsonb' column also, generate a new chain sync dataset with a block that has null characters in other properties
Context
Projecting mainnet NFT metadata throws
invalid byte sequence for encoding "UTF8": 0x00
NFT metadata is user input and string fields can have null characters, which makes postgres query to fail when inserting such data
Proposed Solution
Add a new transformer to sanitize all user-specified string values when inserting NftMetadata entities
Important Changes Introduced
Also add a new chain sync data set that I generated for finding the cause of the issue in
util-dev
package