Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/no-extraneous-dependencies #510

Merged
merged 2 commits into from Nov 8, 2022
Merged

build/no-extraneous-dependencies #510

merged 2 commits into from Nov 8, 2022

Commits on Nov 7, 2022

  1. chore: ignore .yarn from linting concerns

    @rhyslbw
    rhyslbw committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    529b8fe View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. build: fix dependencies as detected by eslint import/no-extraneous-de… 

    …pendencies

This rule, with the configuration to specify test files, ensures packages used in `src` are listed
in the package.json `dependencies`. It will fail if missing or if the dependency is included with
`devDependencies`. Development dependencies are checked against the test directories.

There's a single disable as it's complaining about transitive dependency on `@types/pg` missing
from `dependencies`. We can see if the feature added in
import-js/eslint-plugin-import#2543 handles this scenario once released.
    @rhyslbw
    rhyslbw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    35f7fc9 View commit details
    Browse the repository at this point in the history