This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Remove aspect ratio lock #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MacOS build available here: https://buildkite.com/input-output-hk/mantis-wallet/builds/305#feb03079-e5b1-4c09-9f51-c83239dfca88 |
|
@conqeror |
conqeror
force-pushed
the
remove-locked-aspect-ratio
branch
from
2eb8b74
to
94d1f50
Compare
conqeror
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The locked aspect ratio was proposed when the new designs were WIP and there were still some text overlap and other responsiveness issues with specific aspect ratios.
Since then I made some improvements to the content layout / sidebar which make this fix obsolete.
Why now?
Previously the aspect ratio lock only worked on macOS.
Support for Windows got merged to electron recently: electron/electron#26941
It's time to decide if we want to go with it or ditch it.
If we leave it in place, it's important to test the aspect lock on Windows when we make the electron upgrade.
Proposed Solution
Remove aspect ratio lock.
Testing
Check if there are any issues with reasonable aspect ratios.