Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented non-RDF fetch #104

Merged
merged 11 commits into from
Jun 3, 2020
Merged

Implemented non-RDF fetch #104

merged 11 commits into from
Jun 3, 2020

Commits on Jun 3, 2020

  1. Implemented non-RDF fetch 

    getFile fetches a data blob, and returns it to the user. It uses the underlying fallback fetch, and supports content negociation by allowing the user to pass in headers.
    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    f1db923 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Vincent <Vinnl@users.noreply.github.com>
    @NSeydoux @Vinnl
    NSeydoux and Vinnl committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    197f5fc View commit details
    Browse the repository at this point in the history

  3. Applied suggestions from PR#104

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    7ccd667 View commit details
    Browse the repository at this point in the history

  4. Brought the non-rdf fetching closer to the fetch API 

    In order to not require a documentation additional to the fetch API's, the non-RDF fetching will be closer to the original fetch.
    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    b518af6 View commit details
    Browse the repository at this point in the history

  5. Implemented PR feedback

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    09e865c View commit details
    Browse the repository at this point in the history

  6. Renamed getFile into fetchFile

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    209fd74 View commit details
    Browse the repository at this point in the history

  7. Checks the returned response in tests

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    3d0a492 View commit details
    Browse the repository at this point in the history

  8. Split between the RequestInit options and the the fetcher options

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    8195e0e View commit details
    Browse the repository at this point in the history

  9. Fixed the way options are passed to fetchFile

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    489b059 View commit details
    Browse the repository at this point in the history

  10. Removed outdated comment

    @NSeydoux
    NSeydoux committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    b811e17 View commit details
    Browse the repository at this point in the history

  11. Update src/nonRdfData.ts 

    Co-authored-by: Vincent <Vinnl@users.noreply.github.com>
    @NSeydoux @Vinnl
    NSeydoux and Vinnl committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    41b82c0 View commit details
    Browse the repository at this point in the history