Upgrade to new major version 26 of Jest #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
approved these changes
May 25, 2020
This makes it easier for TypeScript to typecheck our tests, rather relying on `any`-typed globals. For more details, see https://jestjs.io/blog/2020/05/05/jest-26#a-new-way-to-consume-jest---jestglobals Unfortunately, it was not possible to `import { jest } from "@jest/globals"` in files that also call jest.mock(). This was reported here: jestjs/jest#10060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to new major version of Jest. This release did not contain any breaking changes that affects us.
It did introduce a way to import globals rather than relying on them being present implicitly.
Unfortunately, I did run into a bug that that did not combine well with
jest.mock, so those are still relying on the implicitjestglobal. I reported that bug here: jestjs/jest#10060