Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure inspec-core gem depends on rubocop-ast #6925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kellinm
Copy link

@kellinm kellinm commented Jan 10, 2024

Ensure inspec gem depends on rubocop-ast

- Adds `rubocop-ast` to the gemspec file because it was added as a requirement in commit b5fcc141d2.  Without this addition, the inspec gem will exhibit runtime failures because this gem was not installed.

Obvious fix.

Description

When installing inspec-core, the recently introduced dependency on rubocop-ast is missed causing runtime failures.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@kellinm kellinm requested a review from a team as a code owner January 10, 2024 20:07
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for chef-inspec canceled.

Name Link
🔨 Latest commit cbc0bc0
🔍 Latest deploy log https://app.netlify.com/sites/chef-inspec/deploys/65b2b2889fdacc00085acb30

Copy link
Contributor

Hello kellinm! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@clintoncwolfe clintoncwolfe changed the title Ensure inspec gem depends on rubocop-ast Ensure inspec-core gem depends on rubocop-ast Jan 18, 2024
@kellinm
Copy link
Author

kellinm commented Jan 25, 2024

@clintoncwolfe - just wanted to check in and see if you need anything else from me for the review process.

The two failing jobs are not marked required - and I do not have access to check on them to see what failed.

@Vasu1105
Copy link
Contributor

This looks good to me @kellinm. Could you please rebase your branch?

- Adds `rubocop-ast` to the gemspec file because it was added as a
  requirement in commit b5fcc14.  Without this addition, the inspec
  gem will exhibit runtime failures because this gem was not installed.

Obvious fix.

Signed-off-by: Kellin <kellin@retromud.org>
@kellinm
Copy link
Author

kellinm commented Jan 25, 2024

Thank you @Vasu1105 , I have rebased as well as amended my commit message title to match the changed message from maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants