-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure inspec-core gem depends on rubocop-ast #6925
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for chef-inspec canceled.
|
Hello kellinm! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
@clintoncwolfe - just wanted to check in and see if you need anything else from me for the review process. The two failing jobs are not marked required - and I do not have access to check on them to see what failed. |
This looks good to me @kellinm. Could you please rebase your branch? |
187bf50
to
a785644
Compare
- Adds `rubocop-ast` to the gemspec file because it was added as a requirement in commit b5fcc14. Without this addition, the inspec gem will exhibit runtime failures because this gem was not installed. Obvious fix. Signed-off-by: Kellin <kellin@retromud.org>
a785644
to
cbc0bc0
Compare
Thank you @Vasu1105 , I have rebased as well as amended my commit message title to match the changed message from maintainer. |
Description
When installing
inspec-core
, the recently introduced dependency onrubocop-ast
is missed causing runtime failures.Types of changes
Checklist: