feat: Add fallback to Symbol.for(…)
#30
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 206 210 +4
Branches 75 77 +2
=====================================
+ Hits 206 210 +4
Continue to review full report at Codecov.
|
ExE-Boss
force-pushed
the
feat/fallback-to-symbol-for
branch
from
87460ef
to
3a485db
Compare
| @@ -143,6 +149,10 @@ module.exports = function inspect_(obj, options, depth, seen) { | |||
| return String(obj); | |||
| }; | |||
|
|
|||
| if (inspectSymbol) { | |||
| module.exports.custom = inspectSymbol; | |||
There was a problem hiding this comment.
i'd prefer not to re-export this.
| module.exports.custom = inspectSymbol; |
| @@ -16,6 +16,12 @@ var match = String.prototype.match; | |||
| var bigIntValueOf = typeof BigInt === 'function' ? BigInt.prototype.valueOf : null; | |||
|
|
|||
| var inspectCustom = require('./util.inspect').custom; | |||
| /* eslint-disable no-restricted-properties */ | |||
| if (!inspectCustom && typeof Symbol === 'function' && typeof Symbol['for'] === 'function') { | |||
| inspectCustom = Symbol['for']('nodejs.util.inspect.custom'); | |||
There was a problem hiding this comment.
This will mean that in the browser, however, a symbol will be registered and usable. it seems to me that util.inspect's custom symbol should only ever work in node.
There was a problem hiding this comment.
Also, this logic only helps in node >= 10.12; the dependency is still required for node 6.6-10.11, so i don’t see the value in this added complexity.
ljharb
force-pushed
the
master
branch
4 times, most recently
from
7363e8f
to
c2d7746
Compare
ljharb
force-pushed
the
main
branch
2 times, most recently
from
7ada44f
to
431bab2
Compare
Node 10.12 and newer registers the
util.inspect.customsymbol asnodejs.util.inspect.custom, making it possible to useSymbol.for('nodejs.util.inspect.custom')to get the equivalentutil.inspect.customsymbol without depending onutil.