ci: Add missing step for image caching #1114
Merged
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that the cache should be shared between all commits to maximize the advantages of caching |
mqasimsarfraz
force-pushed
the
qasim/add-missing-cache-step
branch
from
d75c292
to
15e0a57
Compare
Yeah, makes sense. Found one more issue regarding |
mqasimsarfraz
force-pushed
the
qasim/add-missing-cache-step
branch
2 times, most recently
from
81a03f0
to
f534e95
Compare
eiffel-fl
reviewed
Nov 16, 2022
mqasimsarfraz
force-pushed
the
qasim/add-missing-cache-step
branch
2 times, most recently
from
b72f8ef
to
193c8f3
Compare
It seems that we are missing step to move the image cache to correct location as per, https://docs.docker.com/build/ci/github-actions/examples/#local-cache
mqasimsarfraz
force-pushed
the
qasim/add-missing-cache-step
branch
from
193c8f3
to
b557c50
Compare
eiffel-fl
approved these changes
Dec 5, 2022
Thanks for the review. Those questions were super important because I understand I will keep this PR open for a bit in case someone else wants to review as well! |
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we are missing step to move the image cache to correct location as per example. Also, the cache sizes
key=Linux-docker-{core,default}-seem to be indicating we aren't using cache for docker images. Only useful for re-triggers of all steps.Testing:
Cache sizes seems to be of the expected sizes with new keys.