Skip to content

Commit

Permalink
chore: fix leaf package-lock.json after lerna version bump
Browse files Browse the repository at this point in the history
Plus, add a hook so that this is taken care of automatically in future,
see lerna/lerna#1415 (comment)
  • Loading branch information
basti1302 committed Apr 25, 2019
1 parent a966de9 commit 6390e8a
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -12,7 +12,7 @@ To make a release, you first need to ensure that the released version will eithe

- Update `CHANGELOG.md` so that the unreleased section gets its version number. Commit this change.
- Run `lerna version patch`, `lerna version minor`, depending on which part of the version number has to be bumped. We should never have the need to bump the major version, so do not run `lerna version major`.
- Lerna will push the commit and the tag created by `lerna version` to GitHub. Check that this has happened.
- Lerna will push the commit and the tag created by `lerna version` to GitHub. Check that this has happened. Also check that the version numbers in package-lock.json have been updated as well.

### Pushing Artifacts to NPM
Once the release is properly committed and tagged, you can release the artifacts to NPM in the following way:
Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -11,7 +11,8 @@
"test:nolint": "lerna run test:nolint --stream",
"test:debug": "lerna run test:debug --stream",
"test:lint": "lerna run test:lint --stream",
"test": "lerna run test --stream"
"test": "lerna run test --stream",
"version": "lerna clean --yes && lerna bootstrap --ignore-scripts -- --package-lock-only --no-audit && git add packages/*/package-lock.json"
},
"devDependencies": {
"@grpc/proto-loader": "^0.3.0",
Expand Down
17 changes: 12 additions & 5 deletions packages/collector/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/legacy-sensor/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6390e8a

Please sign in to comment.