Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverless-collector): added generic serverless collector #1142

Merged
merged 12 commits into from
May 17, 2024

Conversation

joicejoy1988
Copy link
Contributor

@joicejoy1988 joicejoy1988 commented May 6, 2024

refs INSTA-759

Generic serverless collector to trace Node.js applications running in any serverless environment.

Tasks

  • Application logic for serverless-collector package
  • Integration tests
  • QA
  • Add future JIRA card
  • README
  • Tekton Pipeline Changes

Future tasks

  • add public docs
  • add metrics
  • add docker images

@joicejoy1988 joicejoy1988 self-assigned this May 6, 2024
@joicejoy1988 joicejoy1988 requested a review from kirrg001 May 6, 2024 10:32
@kirrg001 kirrg001 assigned kirrg001 and unassigned joicejoy1988 May 7, 2024
@kirrg001 kirrg001 changed the title feat(serverless-collector): generic serverless collector to trace the serverless services feat(serverless-collector): added generic serverless collector May 7, 2024
@kirrg001 kirrg001 force-pushed the generic-serverless-collector-package branch 2 times, most recently from db32ac3 to 95df632 Compare May 8, 2024 09:33
@kirrg001
Copy link
Contributor

@aryamohanan RFR. I will switch & run the Tekton pipeline one more time after your review & before I merge the pull request.

@kirrg001 kirrg001 marked this pull request as ready for review May 10, 2024 10:26
@kirrg001 kirrg001 requested a review from a team as a code owner May 10, 2024 10:26
@kirrg001 kirrg001 force-pushed the generic-serverless-collector-package branch from 8bd20d3 to 415181a Compare May 10, 2024 10:26
@kirrg001 kirrg001 requested a review from aryamohanan May 10, 2024 10:30
## Installation

```sh
npm i @instana/serverless-collector --save
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: When we add a new package to npm we manually need to add package to our Organization. We can consider this in todo list.

@@ -0,0 +1,66 @@
{
"name": "@instana/serverless-collector",
"version": "3.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We released 3.8.1, so don't forget to update the version.

Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirrg001 kirrg001 force-pushed the generic-serverless-collector-package branch from 415181a to eab6c08 Compare May 17, 2024 14:04
@kirrg001 kirrg001 merged commit 1700bf0 into main May 17, 2024
1 check passed
@kirrg001 kirrg001 deleted the generic-serverless-collector-package branch May 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants